F4U-1D: Add Flood Lights#1516
Conversation
|
isn't there a map light or something? |
|
From what i could find the chart board light is only controlled by the knob on the Pilots Distribution Box |
|
Oh - this category is also intended to include the actual outputs of the lights themselves, which should have different draw args from the controls which manage them |
Blackhawkops
force-pushed
the
F4UFloodlights
branch
from
2337758 to
10d3c4a
Compare
|
added outputs and controls for the lights themselves |
| F4U_1D:defineFloat("INTERIOR_CHARTBOARD_LAMP_SWITCH", 637, { 0, 1 }, INTERIOR_LIGHTS, "Chartboard Lamp Switch") | ||
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_SWITCH_LEFT", 638, { 0, 1 }, INTERIOR_LIGHTS, "Left Panel Lamp Switch") | ||
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_SWITCH_RIGHT", 639, { 0, 1 }, INTERIOR_LIGHTS, "Right Panel Lamp Switch") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_SWTICH_LEFT", 640, { 0, 1 }, INTERIOR_LIGHTS, "Left Instrument Board Lamp Switch") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_SWTICH_RIGHT", 641, { 0, 1 }, INTERIOR_LIGHTS, "Right Instrument Board Lamp Switch") |
There was a problem hiding this comment.
Are these "switches" or just "on/off indicators"? (also check the spelling of "SWTICH")
| F4U_1D:definePotentiometer("INTERIOR_PANEL_LAMP_RIGHT", devices.LIGHTS, 3752, 739, { 0, 1 }, INTERIOR_LIGHTS, "Right Panel Lamp UV / Light") | ||
| F4U_1D:definePotentiometer("INTERIOR_INTSRUMENT_BOARD_LAMP_LEFT", devices.LIGHTS, 3753, 740, { 0, 1 }, INTERIOR_LIGHTS, "Left Instrument Board Lamp UV / Light") | ||
| F4U_1D:definePotentiometer("INTERIOR_INTSRUMENT_BOARD_LAMP_RIGHT", devices.LIGHTS, 3754, 741, { 0, 1 }, INTERIOR_LIGHTS, "Right Instrument Board Lamp UV / Light") | ||
| F4U_1D:defineFloat("INTERIOR_CHARTBOARD_LAMP_SWITCH", 637, { 0, 1 }, INTERIOR_LIGHTS, "Chartboard Lamp Switch") |
There was a problem hiding this comment.
Is the corresponding brightness float for this one missing?
There was a problem hiding this comment.
Amended as arg 637 is the brightness float and not a "on/off indicator" and doesn't appear to have a "on/off indicator"
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_BRIGHTNESS_UV_LEFT", 838, { 0, 1 }, INTERIOR_LIGHTS, "Left Panel UV Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_BRIGHTNESS_UV_RIGHT", 839, { 0, 1 }, INTERIOR_LIGHTS, "Right Panel UV Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_BRIGHTNESS_UV_LEFT", 840, { 0, 1 }, INTERIOR_LIGHTS, "Left Instrument Board UV Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_BRIGHTNESS_UV_RIGHT", 841, { 0, 1 }, INTERIOR_LIGHTS, "Right Instrument Board UV Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_BRIGHTNESS_NORMAL_LEFT", 938, { 0, 1 }, INTERIOR_LIGHTS, "Left Panel Normal Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_BRIGHTNESS_NORMAL_RIGHT", 939, { 0, 1 }, INTERIOR_LIGHTS, "Right Panel Normal Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_BRIGHTNESS_NORMAL_LEFT", 940, { 0, 1 }, INTERIOR_LIGHTS, "Left Instrument Board Normal Brightness") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_BRIGHTNESS_NORMAL_RIGHT", 941, { 0, 1 }, INTERIOR_LIGHTS, "Right Instrument Board Normal Brightness") |
There was a problem hiding this comment.
For all lights, the color should be included in parentheses at the end of the description (e.g. Right Panel Normal Brightness (White))
There was a problem hiding this comment.
Amended "Normal" to "White" and updated description with parentheses
Blackhawkops
force-pushed
the
F4UFloodlights
branch
from
10d3c4a to
50836a5
Compare
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_ON_OFF_INDICATOR_LEFT", 638, { 0, 1 }, INTERIOR_LIGHTS, "Left Panel Lamp on/off indicator") | ||
| F4U_1D:defineFloat("INTERIOR_PANEL_LAMP_ON_OFF_INDICATOR_RIGHT", 639, { 0, 1 }, INTERIOR_LIGHTS, "Right Panel Lamp on/off indicator") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_ON_OFF_INDICATOR_LEFT", 640, { 0, 1 }, INTERIOR_LIGHTS, "Left Instrument Board Lamp on/off indicator") | ||
| F4U_1D:defineFloat("INTERIOR_INTSRUMENT_BOARD_LAMP_ON_OFF_INDICATOR_RIGHT", 641, { 0, 1 }, INTERIOR_LIGHTS, "Right Instrument Board Lamp on/off indicator") |
There was a problem hiding this comment.
Can the on/off indicators be defined with defineIndicatorLight? The only states are on and off, right?
Also check that the descriptions are fully Title Cased
There was a problem hiding this comment.
changed to defineindicatorlight for the On/Off args
Blackhawkops
force-pushed
the
F4UFloodlights
branch
from
50836a5 to
ae79266
Compare
charliefoxtwo
left a comment
charliefoxtwo
left a comment
There was a problem hiding this comment.
It looks like INSTRUMENT is misspelled as INTSRUMENT in all controls in this PR
Blackhawkops
force-pushed
the
F4UFloodlights
branch
from
ae79266 to
e6f301d
Compare
2 participants
Fixes #1195